Modernize project codebase (#906)

* Fixed boats falling and a TP glitch #266

* Replaced every C-style cast with C++ ones

* Replaced every C-style cast with C++ ones

* Fixed boats falling and a TP glitch #266

* Updated NULL to nullptr and fixing some type issues

* Modernized and fixed a few bugs

- Replaced most instances of `NULL` with `nullptr`.
- Replaced most `shared_ptr(new ...)` with `make_shared`.
- Removed the `nullptr` macro as it was interfering with the actual nullptr keyword in some instances.

* Fixing more conflicts

* Replace int loops with size_t and start work on overrides

* Add safety checks and fix a issue with vector going OOR

1 files changed, 5 insertions, 5 deletions

diff --git a/Minecraft.World/IndirectEntityDamageSource.cpp b/Minecraft.World/IndirectEntityDamageSource.cpp
index c2a67af5..a24ad1a7 100644
--- a/Minecraft.World/IndirectEntityDamageSource.cpp
+++ b/Minecraft.World/IndirectEntityDamageSource.cpp
@@ -32,26 +32,26 @@ shared_ptr<ChatPacket> IndirectEntityDamageSource::getDeathMessagePacket(shared_
 	shared_ptr<ItemInstance> held = entity->instanceof(eTYPE_LIVINGENTITY) ? dynamic_pointer_cast<LivingEntity>(entity)->getCarriedItem() : nullptr;
 	wstring additional = L"";
 	int type;
-	if(owner != NULL)
+	if(owner != nullptr)
 	{
 		type = owner->GetType();
 		if(type == eTYPE_SERVERPLAYER)
 		{
 			shared_ptr<Player> sourcePlayer = dynamic_pointer_cast<Player>(owner);
-			if(sourcePlayer != NULL) additional = sourcePlayer->name;
+			if(sourcePlayer != nullptr) additional = sourcePlayer->name;
 		}
 	}
 	else
 	{
 		type = entity->GetType();
 	}
-	if(held != NULL && held->hasCustomHoverName() )
+	if(held != nullptr && held->hasCustomHoverName() )
 	{
-		return shared_ptr<ChatPacket>( new ChatPacket(player->getNetworkName(), m_msgWithItemId, type, additional, held->getHoverName() ) );
+		return std::make_shared<ChatPacket>(player->getNetworkName(), m_msgWithItemId, type, additional, held->getHoverName());
 	}
 	else
 	{
-		return shared_ptr<ChatPacket>( new ChatPacket(player->getNetworkName(), m_msgId, type, additional ) );
+		return std::make_shared<ChatPacket>(player->getNetworkName(), m_msgId, type, additional);
 	}
 }